Date
1 - 1 of 1
break statements don't work in spans mode (issue238043)
cku...@...
Reviewers: dev-osl_imageworks.com, osl-dev_googlegroups.com,
Description:
When using the new SHADE_LOOP_BEGIN/END macros in runspans mode, we
actually use two nested loops which means a simple "break" statement
will not work as expected.
This patch adds a new macro: SHADE_LOOP_EXIT which does the right thing,
and fixes all the ops that were using break statements incorrectly.
Please review this at http://codereview.appspot.com/238043/show
Affected files:
src/liboslexec/exec.cpp
src/liboslexec/opcontrol.cpp
src/liboslexec/opmessage.cpp
src/liboslexec/opstring.cpp
src/liboslexec/optexture.cpp
src/liboslexec/opvector.cpp
src/liboslexec/oslops.h
Description:
When using the new SHADE_LOOP_BEGIN/END macros in runspans mode, we
actually use two nested loops which means a simple "break" statement
will not work as expected.
This patch adds a new macro: SHADE_LOOP_EXIT which does the right thing,
and fixes all the ops that were using break statements incorrectly.
Please review this at http://codereview.appspot.com/238043/show
Affected files:
src/liboslexec/exec.cpp
src/liboslexec/opcontrol.cpp
src/liboslexec/opmessage.cpp
src/liboslexec/opstring.cpp
src/liboslexec/optexture.cpp
src/liboslexec/opvector.cpp
src/liboslexec/oslops.h