|
Review: LLVM (issue1734048)
3 messages
Reviewers: , Description: getmessage/setmessage working. I'm not 100% sure about closure messages, since we can't create any closures yet to pass! But I'll return to this and verify after the closure
Reviewers: , Description: getmessage/setmessage working. I'm not 100% sure about closure messages, since we can't create any closures yet to pass! But I'll return to this and verify after the closure
|
By
larry...@...
·
|
|
OSL/LLVM passes OSL *and* Arnold testsuites
The last dragon has been slain. Both OSL and Arnold testsuites full pass with the patch I'm about to commit! Next up: tweedle. -- Larry Gritz l...@...
The last dragon has been slain. Both OSL and Arnold testsuites full pass with the patch I'm about to commit! Next up: tweedle. -- Larry Gritz l...@...
|
By
Larry Gritz
·
|
|
LLVM merge imminent
Update for anybody who doesn't watch the commit list: To combat pesky performance problems of interpreting OSL, we've spent the past few weeks adding an LLVM back end to OSL. LLVM is an open source co
Update for anybody who doesn't watch the commit list: To combat pesky performance problems of interpreting OSL, we've spent the past few weeks adding an LLVM back end to OSL. LLVM is an open source co
|
By
Larry Gritz
·
|
|
build OSL on systems without LLVM (issue1860044)
Reviewers: , Description: This fixes a minor bug so that OSL builds on systems without LLVM installed. Please review this at http://codereview.appspot.com/1860044/show Affected files: src/liboslexec/C
Reviewers: , Description: This fixes a minor bug so that OSL builds on systems without LLVM installed. Please review this at http://codereview.appspot.com/1860044/show Affected files: src/liboslexec/C
|
By
cliffo...@...
·
|
|
build OSL on systems without LLVM (issue1860044)
LGTM -- Larry Gritz l...@...
LGTM -- Larry Gritz l...@...
|
By
Larry Gritz
·
|
|
Review: LLVM displacement bug fix (issue1894042)
2 messages
Reviewers: , Description: In the course of the merge, I broke displacement subtly when not using LLVM. This patch copies out P and N correctly for the interpreter, as we do for the LLVM path, so that
Reviewers: , Description: In the course of the merge, I broke displacement subtly when not using LLVM. This patch copies out P and N correctly for the interpreter, as we do for the LLVM path, so that
|
By
larry...@...
·
|
|
How to assign constant value to closure color?
What is the best way to assign constant value for closure color variable? For example, I'd like to write a shader such like this. surface constant() { Ci = color(1, 0, 0); } Unfortunately, as spec 5.1
What is the best way to assign constant value for closure color variable? For example, I'd like to write a shader such like this. surface constant() { Ci = color(1, 0, 0); } Unfortunately, as spec 5.1
|
By
Syoyo Fujita
·
|
|
Fix closure merge for external defined ones (issue1876042)
10 messages
Reviewers: osl-dev_googlegroups.com, dev-osl_imageworks.com, Description: I forgot to cover the case of external closures in the merge code for ADD. This patch fixes the problem. Please review this at
Reviewers: osl-dev_googlegroups.com, dev-osl_imageworks.com, Description: I forgot to cover the case of external closures in the merge code for ADD. This patch fixes the problem. Please review this at
|
By
aco...@...
·
|
|
Review: displacement bug fix (issue1897048)
4 messages
Reviewers: , Description: Yet another fix to the P & N copying code for displacement to make the interpreter and LLVM work the same way -- don't "find" the symbol from a layer that never was bound. Pl
Reviewers: , Description: Yet another fix to the P & N copying code for displacement to make the interpreter and LLVM work the same way -- don't "find" the symbol from a layer that never was bound. Pl
|
By
larry...@...
·
|
|
Review: oslc fix for indexing (issue1868052)
2 messages
Reviewers: , Description: Component indexing wasn't creating the necessary temporary if the types didn't match. This caused the wrong code to be emitted for something like this: "int i = (int)P[0];" P
Reviewers: , Description: Component indexing wasn't creating the necessary temporary if the types didn't match. This caused the wrong code to be emitted for something like this: "int i = (int)P[0];" P
|
By
larry...@...
·
|
|
OSL talk at SIGGRAPH
4 messages
For anybody who will be at SIGGRAPH in Los Angeles next week, I'm giving a talk about OSL on Wednesday in the "APIs for Rendering" talk session (room 502B at 2pm). My sketch co-authors are Cliff Stein
For anybody who will be at SIGGRAPH in Los Angeles next week, I'm giving a talk about OSL on Wednesday in the "APIs for Rendering" talk session (room 502B at 2pm). My sketch co-authors are Cliff Stein
|
By
Larry Gritz
·
|
|
Review: LLVM optimization pass diddling (issue1696060)
Reviewers: , Description: This rearrangement of LLVM optimization passes approximately doubles the performance of the resulting code. Yes, I know it looks like all the pieces of the engine are splayed
Reviewers: , Description: This rearrangement of LLVM optimization passes approximately doubles the performance of the resulting code. Yes, I know it looks like all the pieces of the engine are splayed
|
By
larry...@...
·
|
|
Review: LLVM optimization pass diddling (issue1696060)
2 messages
For exactly these reasons, I'm not having this reviewed yet. I don't know if the strategy is very helpful, not least because it requires the interpreter to run flawlessly and interchangeably. Though a
For exactly these reasons, I'm not having this reviewed yet. I don't know if the strategy is very helpful, not least because it requires the interpreter to run flawlessly and interchangeably. Though a
|
By
Larry Gritz
·
|
|
How to assign constant value to closure color?
3 messages
Ci = color(1,0,0) * emission(); -- Larry Gritz l...@...
Ci = color(1,0,0) * emission(); -- Larry Gritz l...@...
|
By
Larry Gritz
·
|
|
Group counts
Incidentally, here are the counts of how many points were executed for each shader group in our tweedle test image, at 1/4 res but full sampling. 117 groups in the scene never executed (and thus never
Incidentally, here are the counts of how many points were executed for each shader group in our tweedle test image, at 1/4 res but full sampling. 117 groups in the scene never executed (and thus never
|
By
Larry Gritz
·
|
|
Remove sidedness flag from closures (issue1854047)
2 messages
Reviewers: osl-dev_googlegroups.com, dev-osl <dev-osl_imageworks.com>, Description: And also adding the backfacing() function for the shaders to be able to handle that directly. Please review this at
Reviewers: osl-dev_googlegroups.com, dev-osl <dev-osl_imageworks.com>, Description: And also adding the backfacing() function for the shaders to be able to handle that directly. Please review this at
|
By
aco...@...
·
|
|
Review: back out LLVM pass changes (issue1951042)
Reviewers: , Description: I've spent several days tracking down crashes in our LLVM-generated code, with little satisfaction. I still don't know if this reveals bugs in LLVM or that we have subtly mis
Reviewers: , Description: I've spent several days tracking down crashes in our LLVM-generated code, with little satisfaction. I still don't know if this reveals bugs in LLVM or that we have subtly mis
|
By
larry...@...
·
|
|
Review: back out LLVM pass changes (issue1951042)
3 messages
Effectively, yes. But it's slightly more complex than a simple revert, as it keeps the non-working newer version present but #ifdef-ed out, so I can refer it as we move forward to reconstruct the most
Effectively, yes. But it's slightly more complex than a simple revert, as it keeps the non-working newer version present but #ifdef-ed out, so I can refer it as we move forward to reconstruct the most
|
By
Larry Gritz
·
|
|
Review: restore doInitialization/doFinalization (issue1972042)
Reviewers: , Description: LLVM tweaks: I had commented out the doInitialization/doFinalization calls to the pass manager because they didn't seem to do anything useful. But on a hunch after some very
Reviewers: , Description: LLVM tweaks: I had commented out the doInitialization/doFinalization calls to the pass manager because they didn't seem to do anything useful. But on a hunch after some very
|
By
larry...@...
·
|
|
Fix arg types mismatch in noise call (LLVM) (issue1976041)
6 messages
Reviewers: osl-dev_googlegroups.com, dev-osl <dev-osl_imageworks.com>, Description: We were calling noise functions osl_psnoise_dfdfdfff with the wrong type for the last two arguments. That was trigge
Reviewers: osl-dev_googlegroups.com, dev-osl <dev-osl_imageworks.com>, Description: We were calling noise functions osl_psnoise_dfdfdfff with the wrong type for the last two arguments. That was trigge
|
By
aco...@...
·
|