Part of the windows build now requires the use of MCPP to do the OSL preprocessing. There is a binary available but unfortunatly it doesn't support a necessary command line parameter. So I had to buil

Hi All, I'm trying to compile the OpenShadingLanguage library under Windows using VisualStudio 2008. I was able to compile the following projects so far: - oslquery - oslinfo There is a problem compil

Reviewers: osl-dev_googlegroups.com, Description: We were forgetting to set the pdf in the eval function, plus we were using the wrong cosine in its sampler. Please review this at http://codereview.ap

Reviewers: , Description: At Chris Kulla's suggestion, expand our "debugnan" checking to include the binding step, to catch any bad values passed into the shading system. Please review this at http://

Hey guys, Reading through the OSL manual, on page 20 there's this paragraph: """Functions may be polymorphic. That is, multiple functions may be defined to have the same name, as long as they have dif

Reviewers: , Description: Extend the inf/nan checking to also check (and print specific messages for) derivatives. Also, fixed a minor buglet that, for arrays, would only have checked the first elemen

Sure, I guess I could. I figured that the constants from the oso file were probably beyond reproach, but since it doesn't cost anything, will do. -- lg -- Larry Gritz l...@...

Reviewers: , Description: In several string ops, I used a local var that just told whether any of the arguments were varying, to determine whether to assign to just the first element of Result, or all

Reviewers: , Description: In the same way as my last review for string ops, if getmessage had all uniform args but was called from within a varying conditional, it could fill in only the first value o

Which other cases do you think are broken? I can try to simplify, but it's a fairly complicated set of moving parts. I'll see what I can do. -- lg -- Larry Gritz l...@...

Reviewers: , Description: Like gcc, allow a "-E" option to oslc that just outputs the result of preprocessing. Please review this at http://codereview.appspot.com/201057/show Affected files: src/libos

Reviewers: , Description: adjust_varying is the function that doctors whether a variable is uniform or varying based on what is about to be assigned to it. But if a uniform is being assigned from with

I think it's not. I added it at one point that I was tracking down a bug and never removed it (figuring that it couldn't hurt, and might protect us from subtle bugs some day). I can remove it. Because

Just wondering if you have thought about binding shader parameters to geometry like you can with primitive variables in RenderMan. Specifically - if you are going to do something like this - it would

Reviewers: dev-osl_imageworks.com, osl-dev_googlegroups.com, Description: Two small things I noticed while debugging something unrelated. 1) check_nan was off-by one 2) we allocate space for struct pa

Reviewers: , Description: Ordinarily, it's fine to have type coercion on function parameters, for example, if you pass a float where a color was expected, it'll just do the usual float-to-color conver

How much "space" were we allocating for the struct placeholders? Should be 0, no? Or was the problem just that check_nan was reading bogus heap areas to check nans on these placeholders? -- Larry Grit

Reviewers: dev-osl_imageworks.com, osl-dev_googlegroups.com, Description: Add a new opcode that computes sin and cos together Please review this at http://codereview.appspot.com/205045/show Affected f

I would put in fmath.h: #ifndef __GNUC__ ... define it in terms of sin and cos... #endif -- Larry Gritz l...@...

Reviewers: dev-osl_imagworks.com, osl-dev_googlegroups.com, Description: Array assignment was incorrectly clearing the derivatives of all entries instead of just the derivatives of the entry being ass